u3: restore old-style, efficient reap to u3m_love() #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For posterity, f747d86 is extending the fix from urbit/urbit#1059 to hank cache promotion. |
ashelkovnykov
previously approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Went through this @joemfb . Only part I didn't 100% understand was the hank stuff, but I understood it well enough based on cargo-culting of form to approve this PR.
ashelkovnykov
approved these changes
Nov 29, 2023
pkova
added a commit
that referenced
this pull request
Mar 1, 2024
Reverts #538 My ship ran into a refcounting bug during pre-release testing of vere-v3.0. The only part of the release that touches the relevant codepath is this PR, so we have decided to revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively reverts urbit/urbit#1753, which simplified cache promotion when falling back to an outer road, at the expense of allocation efficiency.
Early testing shows significant positive effects mitigating snapshot patch size (see urbit/urbit#6805)